move extra_float_digits parameter to PgConnectOptions #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're missing a public setter for However, you should already be able to pass this in |
It doesn't work for this parameter, probably because the parameter is sent twice if I use the |
|
Closed by #1774 Sorry, but I wanted to put more in the documentation for the method and change the signature to accept |
|
don't worry, my goal was achieved anyway. Thanks for the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
extra_float_digitstoPgConnectOptionsto allow overriding the parameter.This solves one of the issues mentioned in #801